This repository has been archived by the owner on May 23, 2023. It is now read-only.
Make the build green again #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were broken (lots of undefined names) and no longer used as pyethash is now listed in requirements.txt
It only uses flake8 to check for fatal errors
|
This is something I've been needing too. How did the testing build get in the current situation? I don't exactly understand what broke. |
|
A lot of changes were merged recently, and they broke several tests. Because of that we can no longer rely on travis to prevent regressions, and now we even have plenty of syntax errors (undefined names, mostly) in the codebase |
|
I think it's better to keep |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the current state of things, the CI for pyethereum is completely useless as it is interrupted before we even run any tests (since pytest fails to "collect" them). Since most tests are failing and lots of them even have syntax errors, I'm proposing we change the CI script to perform only minimal checks for now, and then we can fix and re-enable tests individually.