Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .gitignore & committing .pot files #3118

Merged
merged 3 commits into from
Nov 1, 2022
Merged

update .gitignore & committing .pot files #3118

merged 3 commits into from
Nov 1, 2022

Conversation

ryestew
Copy link
Collaborator

@ryestew ryestew commented Sep 28, 2022

Updated .gitignore - but I did include doctrees - so I may be committing too much to the repo.
see dragfish's comments: #3117

The updated .pot files had only been saved locally - but with the update to .gitignore, they are being committed.

@drafish
Copy link
Contributor

drafish commented Sep 29, 2022

Rob, you need to install the new parser myst-parser and regenerate the pot files. Now, it' just the old files parsed by recommonmark. @ryestew

@ryestew
Copy link
Collaborator Author

ryestew commented Sep 29, 2022

updated - but do not merge yet - there is an issue with images

@drafish
Copy link
Contributor

drafish commented Oct 24, 2022

image
If anyone wondering why there is this metion. It's because I misunderstood about what @ryestew said there is an issue with images. I submit a issue in MyST repository, and metioned.

Then I found out that images didn't render correctly. I realized that this should be the issue. I already submit a PR to fix it.

And I tried to remove this mistaken metion. But it seems like unremovable.

@yann300 yann300 merged commit 18caf1c into master Nov 1, 2022
@yann300 yann300 deleted the gitIgnUpdate branch November 1, 2022 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants