Circuit compiler UI #4144

ioedeveloper · 2023-10-17T09:00:12Z

User Interface for Circom Plugin

netlify · 2023-10-17T09:00:38Z

✅ Deploy Preview for remixproject ready!

Name	Link
🔨 Latest commit	`1849efb`
🔍 Latest deploy log	https://app.netlify.com/sites/remixproject/deploys/6540c338e0961b00095ebb9a
😎 Deploy Preview	https://deploy-preview-4144--remixproject.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bunsenstraat · 2023-10-18T15:29:21Z

apps/circuit-compiler/src/app/app.tsx


  useEffect(() => {
-    new CircomPluginClient()
+    const plugin = new CircomPluginClient()


setting plugin clients in useeffect and in a state will cause problems. especially when using strict mode. I've seen situations with other plugins doing this where it would either try to connect to Remix twice or never connect at all. You can can listen on the onload event here just fine. but I'd set the plugin as a const and export it.

Can you make a commit with your recommended changes?

ryestew · 2023-10-19T13:30:48Z

The name should updated to:
Circom ZKP compiler

ryestew · 2023-10-19T13:31:05Z

Links to docs and we need a medium article.

ryestew · 2023-10-19T13:36:07Z

Needs a button to make some example files - but if this is a workspace and a workspace is created - somehow the user needs to be informed that a workspace has been created. So you could generate workspace and automatically get switched to the FE.

ryestew · 2023-10-19T13:37:21Z

and we need documentation for this plugin

yann300 · 2023-10-25T08:18:20Z

apps/circuit-compiler/src/profile.json

@@ -8,8 +8,8 @@
  "canActivate": [],
  "url": "",
  "description": "Enables circuit compilation and computing a witness for ZK proofs",
-  "icon": "https://docs.circom.io/assets/images/favicon.png",
-  "location": "hiddenPanel",
+  "icon": "assets/img/circom.webp",


the icon doesn't show up...

bunsenstraat · 2023-10-25T10:31:16Z

apps/circuit-compiler/src/app/services/circomPluginClient.ts


  constructor() {
    super()
    createClient(this)
    this.internalEvents = new EventManager()
-    this.methods = ['init', 'parse']


set the methods before the createclient

If I remember correctly :D

bunsenstraat · 2023-10-30T08:13:19Z

I think you can add the plugin tor required plugins in app manager so you don't have to give permissions.

bunsenstraat · 2023-10-30T08:19:07Z

apps/remix-ide/src/app/files/fileManager.ts

@@ -255,13 +255,13 @@ class FileManager extends Plugin {
   * @param {string} path path of the file
   * @returns {string} content of the file
   */
-  async readFile(path) {
+  async readFile(path, isBuffer?) {


if we start doing this we should maybe just add encoding as a param, which is the standard fs way. so we can support everything.

ryestew

For translations, you have updated the index.js and the circuit.json file in remix-ide/src/app/tabs/locales/en.

You don't need to add the circuit.json file in the es, fr, and zh folders. Please remove these .json files - only keep the one in the en folder.

ioedeveloper requested review from bunsenstraat, ryestew, yann300, LianaHus and Aniket-Engg October 17, 2023 09:00

bunsenstraat reviewed Oct 18, 2023

View reviewed changes

ioedeveloper force-pushed the circuit-compiler branch from 9aefc74 to 7144c89 Compare October 19, 2023 11:11

ioedeveloper added this to In progress in v0.38.0 - Feature Freeze 29/11 via automation Oct 19, 2023

ioedeveloper added the ready-to-review PR ready to review label Oct 19, 2023

ioedeveloper added this to the Zero Knowledge milestone Oct 19, 2023

ryestew added the documentation-needed Documentation should be updated label Oct 19, 2023

ioedeveloper force-pushed the circuit-compiler branch from e2fec28 to 75bd995 Compare October 20, 2023 14:25

yann300 reviewed Oct 25, 2023

View reviewed changes

bunsenstraat reviewed Oct 25, 2023

View reviewed changes

ioedeveloper removed this from In progress in v0.38.0 - Feature Freeze 29/11 Oct 25, 2023

ioedeveloper added this to In progress in 0.37.0 - Feature Freeze 31/10 - Release 07/11 via automation Oct 25, 2023

ioedeveloper force-pushed the circuit-compiler branch from 5c7f5de to ba4cfea Compare October 26, 2023 12:43

yann300 requested a review from bunsenstraat October 26, 2023 12:51

ioedeveloper force-pushed the circuit-compiler branch from 583b275 to ddcdf3f Compare October 27, 2023 11:29

bunsenstraat requested changes Oct 30, 2023

View reviewed changes

0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from In progress to Review in progress Oct 30, 2023

ioedeveloper mentioned this pull request Oct 30, 2023

Semaphore template #4164

Merged

ioedeveloper force-pushed the circuit-compiler branch from 46562f3 to 26ddc61 Compare October 30, 2023 11:48

ryestew reviewed Oct 31, 2023

View reviewed changes

ioedeveloper and others added 26 commits October 31, 2023 10:04

Initialize circom UI

bb28855

Compile circom code with play button

7773a82

Fetch compile wasm binaries

8f8b56e

Compile and generate R1CS UI

4a40340

Add compute witness button

63620c8

Save witness file

f0d76b9

Show errors and warnings

dd7966a

Fix compilation blocking for warnings thrown

0bfbb83

Change new format for parsed report

e2b16a2

Implemented open error file location

ae21c6f

Implemented hide warnings

e7e0751

Reorder props

fdff81e

Update circom_wasm

0d3ed7a

Change circom plugin icon

20e8c8b

Fix compute feedback

7ef7d31

Update circom compiler display name

72bcde0

Update app.tsx

639682f

remove useState

0d95054

Update plugin icon

9c9606d

Set methods before calling createClient

44e900f

Wait for plugin activated

57c5857

Expose more circuit-compiler versions

ae71ea5

Update yarn-lock file

49df0ba

Make circuit-compiler a required plugin

5b9be5c

Include encoding param

4e0d5f1

Switch plugin icon

1849efb

ioedeveloper force-pushed the circuit-compiler branch from e0c3490 to 1849efb Compare October 31, 2023 09:04

ioedeveloper merged commit 50d745d into master Oct 31, 2023
32 checks passed

0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from Reviewer approved to Done Oct 31, 2023

ioedeveloper deleted the circuit-compiler branch October 31, 2023 09:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Circuit compiler UI #4144

Circuit compiler UI #4144

ioedeveloper commented Oct 17, 2023

netlify bot commented Oct 17, 2023 •

edited

bunsenstraat Oct 18, 2023

ioedeveloper Oct 19, 2023

bunsenstraat Oct 20, 2023

ryestew commented Oct 19, 2023

ryestew commented Oct 19, 2023

ryestew commented Oct 19, 2023

ryestew commented Oct 19, 2023

yann300 Oct 25, 2023

bunsenstraat Oct 25, 2023

bunsenstraat Oct 25, 2023

bunsenstraat commented Oct 30, 2023

bunsenstraat Oct 30, 2023

ryestew left a comment

Circuit compiler UI #4144

Circuit compiler UI #4144

Conversation

ioedeveloper commented Oct 17, 2023

netlify bot commented Oct 17, 2023 • edited

✅ Deploy Preview for remixproject ready!

bunsenstraat Oct 18, 2023

Choose a reason for hiding this comment

ioedeveloper Oct 19, 2023

Choose a reason for hiding this comment

bunsenstraat Oct 20, 2023

Choose a reason for hiding this comment

ryestew commented Oct 19, 2023

ryestew commented Oct 19, 2023

ryestew commented Oct 19, 2023

ryestew commented Oct 19, 2023

yann300 Oct 25, 2023

Choose a reason for hiding this comment

bunsenstraat Oct 25, 2023

Choose a reason for hiding this comment

bunsenstraat Oct 25, 2023

Choose a reason for hiding this comment

bunsenstraat commented Oct 30, 2023

bunsenstraat Oct 30, 2023

Choose a reason for hiding this comment

ryestew left a comment

Choose a reason for hiding this comment

netlify bot commented Oct 17, 2023 •

edited