Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semaphore template #4164

Merged
merged 7 commits into from
Oct 31, 2023
Merged

Semaphore template #4164

merged 7 commits into from
Oct 31, 2023

Conversation

ioedeveloper
Copy link
Member

No description provided.

@ioedeveloper ioedeveloper added this to In progress in 0.37.0 - Feature Freeze 31/10 - Release 07/11 via automation Oct 25, 2023
@netlify
Copy link

netlify bot commented Oct 25, 2023 •
edited

✅ Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 8c7115c
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/6540ec143ba95b00080cdded
😎 Deploy Preview https://deploy-preview-4164--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ioedeveloper ioedeveloper added this to the Zero Knowledge milestone Oct 25, 2023
@yann300
Copy link
Contributor

yann300 commented Oct 25, 2023

When a semaphore template is being created, probably we should activate the circom plugin.

@ioedeveloper ioedeveloper marked this pull request as ready for review October 27, 2023 12:15
@ioedeveloper ioedeveloper added the ready-to-review PR ready to review label Oct 27, 2023
@bunsenstraat
Copy link
Collaborator

When a semaphore template is being created, probably we should activate the circom plugin.

In the PR the circuit plugin doesn't load right? is that correct?

@yann300
Copy link
Contributor

yann300 commented Oct 30, 2023

When a semaphore template is being created, probably we should activate the circom plugin.

In the PR the circuit plugin doesn't load right? is that correct?

In this PR I don't think so, it probably should

@ioedeveloper
Copy link
Member Author

When a semaphore template is being created, probably we should activate the circom plugin.

In the PR the circuit plugin doesn't load right? is that correct?

In this PR, the circuit-compiler UI is not present, it only contains semaphore template. This PR has the changes for circuit-compiler UI #4144

@yann300
Copy link
Contributor

yann300 commented Oct 30, 2023

When a semaphore template is being created, probably we should activate the circom plugin.

In the PR the circuit plugin doesn't load right? is that correct?

In this PR, the circuit-compiler UI is not present, it only contains semaphore template. This PR has the changes for circuit-compiler UI #4144

ok so let's do it in an another PR..

0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from In progress to Reviewer approved Oct 31, 2023
@ioedeveloper ioedeveloper merged commit 135b5da into master Oct 31, 2023
32 checks passed
0.37.0 - Feature Freeze 31/10 - Release 07/11 automation moved this from Reviewer approved to Done Oct 31, 2023
@ioedeveloper ioedeveloper deleted the semaphore-template branch October 31, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yann300 yann300 yann300 approved these changes

@bunsenstraat bunsenstraat Awaiting requested review from bunsenstraat

@Aniket-Engg Aniket-Engg Awaiting requested review from Aniket-Engg

Assignees
No one assigned
Labels
ready-to-review PR ready to review
Projects
No open projects
0.37.0 - Feature Freeze 31/10 - Relea...
  
Done
Milestone
Zero Knowledge
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ioedeveloper @yann300 @bunsenstraat