Track More Metrics for Circom with Matomo #5026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ioedeveloper
commented
Jul 19, 2024
•
ioedeveloper
commented
- Updated path for circom template scripts in other to uniquely identify scripts that are ran for circom.
- Updated e2e tests with new path to fix failing test.
✅ Deploy Preview for remixproject ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Aniket-Engg
reviewed
Jul 22, 2024
| @@ -208,6 +208,7 @@ export const createWorkspace = async ( | |||
| if (workspaceTemplateName === 'semaphore' || workspaceTemplateName === 'hashchecker' || workspaceTemplateName === 'rln') { | |||
| const isCircomActive = await plugin.call('manager', 'isActive', 'circuit-compiler') | |||
| if (!isCircomActive) await plugin.call('manager', 'activatePlugin', 'circuit-compiler') | |||
| _paq.push(['trackEvent', 'circuit-compiler', 'template', 'create', workspaceTemplateName]) | |||
There was a problem hiding this comment.
are we generally using 5 params with _paq.push ?
There was a problem hiding this comment.
No, i think you can use as many
Aniket-Engg
approved these changes
Jul 22, 2024
joeizang
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.