-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix --standard-json on solcjs #127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
approved these changes
Jul 25, 2017
Tests are failing. |
Not sure yet why, it works locally on my computer. |
b85bd88
to
335a44d
Compare
38a782f
to
2eea20f
Compare
Fixed it, |
f45e158
to
c806756
Compare
watilde
reviewed
Sep 29, 2017
529f358
to
5bef54c
Compare
3bb9899
to
9e1687e
Compare
93292b6
to
4135f16
Compare
Lets merge #260 first and see if this works on all node versions. |
4135f16
to
2cd5d8e
Compare
66377cb
to
2cd5d8e
Compare
3b25123
to
00892bc
Compare
chriseth
requested changes
Dec 3, 2018
00892bc
to
30b7a42
Compare
@chriseth updated |
chriseth
approved these changes
Dec 3, 2018
Didn't remove Node 4 from circleci :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126. Closes #263.