Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --standard-json on solcjs #127

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Fix --standard-json on solcjs #127

merged 2 commits into from
Dec 3, 2018

Conversation

axic
Copy link
Member

@axic axic commented Jul 25, 2017 •
edited

Fixes #126. Closes #263.

@axic axic requested a review from chriseth July 25, 2017 14:26
@chriseth
Copy link
Contributor

Tests are failing.

@axic
Copy link
Member Author

axic commented Jul 25, 2017

Not sure yet why, it works locally on my computer.

@axic axic force-pushed the solcjs-standard branch 2 times, most recently from b85bd88 to 335a44d Compare July 25, 2017 19:30
@axic axic mentioned this pull request Aug 24, 2017
Closed
@axic axic force-pushed the solcjs-standard branch 2 times, most recently from 38a782f to 2eea20f Compare September 25, 2017 12:09
@axic
Copy link
Member Author

axic commented Sep 25, 2017 •
edited

Fixed it, spt.stdin.end() was prematurely closing the pipe, before travis (or any other slower system) managed to push the actual json.

@axic axic force-pushed the solcjs-standard branch 2 times, most recently from f45e158 to c806756 Compare September 27, 2017 09:57
watilde
watilde reviewed Sep 29, 2017
View reviewed changes
test/cli.js Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited

Coverage Status

Coverage remained the same at 56.982% when pulling 5e70070 on solcjs-standard into 0bb4853 on master.

@axic
Copy link
Member Author

axic commented Sep 27, 2018

Lets merge #260 first and see if this works on all node versions.

@axic axic force-pushed the solcjs-standard branch 2 times, most recently from 66377cb to 2cd5d8e Compare October 4, 2018 22:58
@axic axic mentioned this pull request Nov 30, 2018
Merged
chriseth
chriseth requested changes Dec 3, 2018
View reviewed changes
solcjs Outdated Show resolved Hide resolved
solcjs Outdated Show resolved Hide resolved
@leonardoalt
Copy link
Member

@chriseth updated

@chriseth chriseth merged commit c6c6ecd into master Dec 3, 2018
@axic
Copy link
Member Author

axic commented Dec 3, 2018

Didn't remove Node 4 from circleci :)

This was referenced Dec 3, 2018
Closed
Closed
@axic axic deleted the solcjs-standard branch December 20, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@watilde watilde watilde left review comments

@tzapu tzapu tzapu left review comments

@chriseth chriseth chriseth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@axic @chriseth @coveralls @leonardoalt @watilde @tzapu