apply CR comments

ethereum · Dec 4, 2023 · e21eab9 · e21eab9
1 parent 8aad1b4
commit e21eab9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/libsolidity/formal/PredicateInstance.cpp b/libsolidity/formal/PredicateInstance.cpp
@@ -51,7 +51,7 @@ smtutil::Expression nondetInterface(
 {
 	auto const& state = _context.state();
 	std::vector<smtutil::Expression> stateExprs{state.errorFlag().currentValue(), state.thisAddress(),
-		state.abi(), state.bytesConcat(0), state.crypto()};
+		state.abi(), state.bytesConcat(), state.crypto()};
 	return _pred(
 		stateExprs +
 		std::vector<smtutil::Expression>{_context.state().state(_preIdx)} +

diff --git a/libsolidity/formal/SMTEncoder.cpp b/libsolidity/formal/SMTEncoder.cpp
@@ -810,7 +810,7 @@ void SMTEncoder::visitBytesConcat(FunctionCall const& _funCall)
 		if (args.at(i))
 			symbArgs.emplace_back(expr(*args.at(i), inTypes.at(i)));
 
-	std::optional<smtutil::Expression> arg;
+	smtutil::Expression arg;
 	if (inTypes.size() == 1)
 		arg = expr(*args.at(0), inTypes.at(0));
 	else
@@ -824,8 +824,6 @@ void SMTEncoder::visitBytesConcat(FunctionCall const& _funCall)
 
 	auto out = smtutil::Expression::select(symbFunction, *arg);
 	defineExpr(_funCall, out);
-
-	return;
 }
 
 void SMTEncoder::visitABIFunction(FunctionCall const& _funCall)