Switch working dir to test dir in command-line tests #13437
Labels
closed due inactivity
The issue/PR was automatically closed due to inactivity.
good first issue candidate
Could be a "good first issue" but something is blocking it or it has open questions.
low effort
There is not much implementation work to be done. The task is very easy or tiny.
low impact
Changes are not very noticeable or potential benefits are limited.
nice to have
We don’t see a good reason not to have it but won’t go out of our way to implement it.
stale
The issue/PR was marked as stale because it has been open for too long.
testing 🔨
Abstract
Currently, when running command-line tests, the working directory is set to
test/cmdlineTests/
and not the directory of the specific test case. This means that we need to repeat the name of the test case (which is often long) to refer to a file inside it.This is not a big problem as long as we rely on the test runner inserting the file path automatically. There are, however, cases where we do have to spell out the path. For example:
solidity/test/cmdlineTests/standard_debug_info_in_yul_and_evm_asm_print_all/input.json
Lines 3 to 5 in f802eaf
We should be able to do
"C": {"urls": ["in.sol"]}
instead.Specification
Adjust
cmdlineTests.sh
so that it enters test case dir before running it and exits it afterwards. Then remove any hard-coded test case names from test inputs and regenerate expectations.The text was updated successfully, but these errors were encountered: