-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semver checker doesn't work with ^0 #5081
Comments
If someone takes this, please check if it should work or not. |
According to the docs that should not work since will allow only the right most number to be anything to avoid breaking changes. However, this is not the behaivour specified in npm, and the docs clearly state that "It is possible to specify much more complex rules for the compiler version, the expression follows those used by npm." If I am not mistaken theres is a contradiction in the documentation. |
I do believe there is an issue if npm rules are accepted. According to npm docs "A missing minor and patch values will desugar to zero, but also allow flexibility within those values, even if the major version is zero." so |
Can I take this one if no one is working on it? |
@HenryRLee Sure. This one is up for grabs. Please assign yourself then. |
Thanks, @erak. I'll start working on it. But I don't think I have the privilege to self-assign. |
Great! I've assigned this issue to you now. Thanks. |
Version Checker: 0.5.x-prerelease will match `pragma solidity ^0.5` #5081
Fixed by #7583 |
I think
^0
should work for any0.y.z
version, but I may be mistaken.The text was updated successfully, but these errors were encountered: