Remove the inaccurate Type::categoryName()
#14143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge for invalid calls to one independent of the category
r0qs
reviewed
Apr 20, 2023
r0qs
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts most of my changes from #14087 and tweaks the error message in a different way, that does not require printing the type.
Discussion for reference: #12656 (comment), #12656 (comment).
The main problem with
Type::categoryName()is that for most values it tries to describe the instance of the type, rather than the category - which fits the error message but is not a good formatter for that enum in general. I could fix it, but I actually found a better way to word it independently of its type (compared to #14087 (comment)), so I'll go with that instead.