Add support for parsing debug data attributes #14857
Conversation
github-actions
bot
added
the
stale
ekpyron
removed
the
stale
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
from
47e3966
to
be1913d
Compare
aarlt
changed the base branch from
develop
to
replace-jsoncpp-with-nlohmann-json
aarlt
added
the
has dependencies
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
3 times, most recently
from
b17a4f7
to
fe70d58
Compare
aarlt
force-pushed
the
replace-jsoncpp-with-nlohmann-json
branch
from
a0eb445
to
84df68d
Compare
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
3 times, most recently
from
8221ce1
to
6396d56
Compare
github-actions
bot
added
the
stale
aarlt
removed
the
stale
aarlt
force-pushed
the
replace-jsoncpp-with-nlohmann-json
branch
3 times, most recently
from
983f48b
to
d2bb60a
Compare
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
from
6396d56
to
e983c75
Compare
aarlt
force-pushed
the
replace-jsoncpp-with-nlohmann-json
branch
from
7d1853c
to
0ab7dbc
Compare
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
from
e983c75
to
539a523
Compare
github-actions
bot
added
the
stale
aarlt
force-pushed
the
replace-jsoncpp-with-nlohmann-json
branch
from
0ab7dbc
to
cb2b661
Compare
aarlt
removed
the
stale
aarlt
force-pushed
the
replace-jsoncpp-with-nlohmann-json
branch
4 times, most recently
from
c0710bf
to
87d86bf
Compare
aarlt
removed
the
stale
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
15 times, most recently
from
a783743
to
161f0b1
Compare
aarlt
changed the title
cameel
changed the title
cameel
changed the title
github-actions
bot
added
the
stale
aarlt
removed
the
stale
aarlt
force-pushed
the
yul_parse_debugdata_attributes
branch
from
161f0b1
to
34249a2
Compare
ekpyron
removed
the
has dependencies
| } | ||
| } | ||
| // ---- | ||
| // SyntaxError 5721: (37-65): @debug.merge: Could not parse debug data: parse error at line 1, column 12: syntax error while parsing object - unexpected end of input; expected '}' |
There was a problem hiding this comment.
Will this always error out now on invalid @debug.* attributes? What happened before if we had this kind of attribute? If this compiled before the change, we need to wonder if this is breaking (and should only be parsed if enabled somehow) - even though it may be fine in practice. But can you explain how this behaved before the PR?
There was a problem hiding this comment.
@cameel what would you say to this? this is technically breaking, but would you say its ok?
There was a problem hiding this comment.
I think I will just base on #15289. So attribute parsing is only enabled, if ethdebug was requested.
There was a problem hiding this comment.
Looks like this would be ignored before and now it is an error. I checked now and I see that when we introduced the @src tag we did it like this too - solc 0.8.8 just started issuing errors on invalid @src tags. So there is a precedent for ignoring such minor breaking changes.
Similarly in #15209, we were careful not to be completely breaking, but it was still too constraining to keep it 100% compatible for every minor irrelevant detail - e.g. now single quotes are supported and you'll get an error on an unmatched quote, which previously would have been not recognized as the beginning of a string and ignored.
So I'd say it's fine if it's a minor thing unlikely to happen in practical use and the alternative requires too much effort. It should still be documented in the changelog though. Looks like you found a good alternative though - parsing it only with ethdebug enabled - so I'd go with that.
Depends on