Explicit treatment of printing mode in Yul AsmPrinter #15259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 12, 2024
5 tasks
aarlt
reviewed
Jul 23, 2024
aarlt
reviewed
Jul 23, 2024
cameel
previously approved these changes
Jul 24, 2024
clonker
force-pushed
the
asm_printer_mode
branch
3 times, most recently
from
7c3550a
to
87a006c
Compare
|
Thanks @cameel! I implemented your suggestions. |
cameel
previously approved these changes
Jul 24, 2024
clonker
force-pushed
the
asm_printer_mode
branch
from
87a006c
to
dafc9c2
Compare
clonker
force-pushed
the
asm_printer_mode
branch
from
dafc9c2
to
f89e83b
Compare
cameel
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the YulNameRepository is merged, the AsmPrinter will need to have an instance of it anyways (which contains the dialect), so I changed the AsmPrinter s.t. the printing mode is explicitly specified instead of implicitly inferred from whether a dialect pointer is null or not.