-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EIP-3540 and EIP-3670 Tests to Cancun #1193
Conversation
no, first letes decouple it from normal tests |
this might be not needed now. as the tests are in separate folder and don't interfere with Hive |
87d7b04
to
a7c3a56
Compare
I have updated the PR to place the tests in the correct directory. Leaving it as Cancun as it is how Evmone is currently expecting it. Also this PR updates the tests due to new logic of how nonce is incremented in some invalid EOF code. |
- ':label deploying_0xef0000 :raw 0x60ef60005360036000f3' | ||
#- ':yul { mstore8(0, 0xef) return(0, 32) }' | ||
- ':label deploying_0xef00..00 :raw 0x60ef60005360206000f3' | ||
- ':label deploying_0xef :yul-eof { mstore8(0, 0xef) return(0, 1) }' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is yul-eof let me add it to the config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the yul-eof script: https://github.com/hugo-dc/retesteth-config/blob/eof/default/yul-eof.sh
It's using solidity from this branch: https://github.com/ethereum/solidity/tree/eof-functions
@@ -80,7 +76,7 @@ CREATE2_EOF1_FromEOF: | |||
- indexes: | |||
data: ':label deploying_0xef' | |||
network: | |||
- 'Shanghai' | |||
- 'Cancun' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>=Cancun
so the test get generated a vector after Cancun too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
Draft? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rebase on develop
bb8e788
to
b5ea56b
Compare
No description provided.