Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-3540 and EIP-3670 Tests to Cancun #1193

Merged
merged 4 commits into from
Mar 31, 2023

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Mar 14, 2023

No description provided.

@hugo-dc hugo-dc marked this pull request as ready for review March 14, 2023 00:46
@winsvega
Copy link
Collaborator

no, first letes decouple it from normal tests
#1192

@winsvega
Copy link
Collaborator

this might be not needed now. as the tests are in separate folder and don't interfere with Hive

@hugo-dc hugo-dc marked this pull request as draft March 16, 2023 17:45
@hugo-dc
Copy link
Member Author

hugo-dc commented Mar 17, 2023

I have updated the PR to place the tests in the correct directory. Leaving it as Cancun as it is how Evmone is currently expecting it. Also this PR updates the tests due to new logic of how nonce is incremented in some invalid EOF code.

- ':label deploying_0xef0000 :raw 0x60ef60005360036000f3'
#- ':yul { mstore8(0, 0xef) return(0, 32) }'
- ':label deploying_0xef00..00 :raw 0x60ef60005360206000f3'
- ':label deploying_0xef :yul-eof { mstore8(0, 0xef) return(0, 1) }'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is yul-eof let me add it to the config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -80,7 +76,7 @@ CREATE2_EOF1_FromEOF:
- indexes:
data: ':label deploying_0xef'
network:
- 'Shanghai'
- 'Cancun'
Copy link
Collaborator

@winsvega winsvega Mar 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>=Cancun so the test get generated a vector after Cancun too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@winsvega
Copy link
Collaborator

Draft?

@hugo-dc hugo-dc marked this pull request as ready for review March 28, 2023 04:50
Copy link
Collaborator

@winsvega winsvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase on develop

@winsvega winsvega merged commit 1e08b48 into ethereum:develop Mar 31, 2023
@gumb0 gumb0 deleted the update-3540-3670-cancun branch April 3, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants