-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new RLP test #562
add new RLP test #562
Conversation
the output I got with aleth:
|
@winsvega @holgerd77 output from rust rlp library
|
Could yoy post rlp that rust calculate in a hex binary string representation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aleth failing on this test.
up |
@gumb0, do you think there is a bug in aleth RLP implementation here ? |
It looks like the trailing zeroes in
are beyond the data size given in the prefix, i.e. it's trailing data outside of RLP. So aleth's implementation returns "OversizeRLP" error on this. |
expired |
We discovered that our implementation of RLP encoding decodes some RLP binaries incorrectly after recent PR (mana-ethereum/ex_rlp#17) but it passes all RLP test cases.
This PR adds a new test case which is not covered by existing RLP tests