refactor: extract trin-execution/e2store + clean dependencies #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
changed the title
KolbyML
force-pushed
the
trin-execution
branch
3 times, most recently
from
0855667
to
4476f6f
Compare
morph-dev
approved these changes
Jun 24, 2024
e2store/README.md
Outdated
|
|
||
| ## What is era1 | ||
|
|
||
| era1 is a format for storing all of Ethereum's post merge blocks. It contains block headers, block bodies, and receipts for block 0-15537394 |
There was a problem hiding this comment.
nit: Should this be pre-merge?
There was a problem hiding this comment.
I meant in the first sentence:
era1 is a format for storing all of Ethereum's post merge blocks
Should this be "post merge" or "pre merge"?
trin-execution/Cargo.toml
Outdated
| surf = { version = "2.3.2", default-features = false, features = ["h1-client-rustls", "middleware-logger", "encoding"] } # we use rustls because OpenSSL cause issues compiling on aarch64 | ||
| test-log = { version = "0.2.11", features = ["trace"] } | ||
| tokio = { version = "1.14.0", features = ["full"] } | ||
| tracing-test = "0.1" |
There was a problem hiding this comment.
nit: Is there newline at the end? I think it should be.
trin-execution/tests/state.rs
Outdated
| const ERA1_FILE_COUNT: usize = 1897; | ||
|
|
||
| /// Fetches era1 files hosted on era1.ethportal.net and shuffles them | ||
| async fn get_shuffled_era1_files(http_client: &Client) -> anyhow::Result<Vec<String>> { |
There was a problem hiding this comment.
nit: maybe move this into e2store? Something like test_utils?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
portal-bridgetypes, but was rapidly outgrowing its position here.How was it fixed?