feat: add more metrics to trin execution #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morph-dev
approved these changes
Aug 5, 2024
| @@ -3,7 +3,7 @@ apiVersion: 1 | |||
| datasources: | |||
| - name: Prometheus | |||
| type: prometheus | |||
| url: http://prometheus:9090 | |||
| url: http://localhost:9090 | |||
There was a problem hiding this comment.
Maybe I need to add another separate datasource to support both macos and linux, but what I do know, is http://prometheus:9090 doesn't work on linux
There was a problem hiding this comment.
I think because of my updates to docker-compose this should work. I don't run this on macos anymore, so if someone finds a bug we can fix it then
| - targets: ["host.docker.internal:9091"] | ||
| - targets: | ||
| - host.docker.internal:9091 | ||
| - localhost:9091 |
There was a problem hiding this comment.
not sure about this one either (but it might be ok, since it has both)
There was a problem hiding this comment.
This is so both MacOS works and Linux
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milos said I should try to take what I can from my big PR so I will do that, I will need a week to split .era2 PR more, but I will pull out anything that can be reviewed which can't break my database code for now
What was wrong?
There wasn't enough metrics to understand things like transaction progress times, storage etc
How was it fixed?
By updating