This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Upgrade py-evm to v0.3.0a9 #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The wheel failures are real, from a recent ipython release. We were hooking into some non-public API which disappeared, and prevented us from attaching. So all the |
|
Ok, so ipython 7.10.1 gives a mysterious blinking ...(etc) So it looks like it's |
ipython v7.10.1 gives a mysterious blinking `Press ENTER to continue...`.
v7.10.0 shows what's going on by spitting out this exception over and over:
Press ENTER to continue...
Exception 'Loop' object has no attribute '_ready'
Unhandled exception in event loop:
File "uvloop/cbhandles.pyx", line 68, in uvloop.loop.Handle._run
File "/tmp/fresh-venv/lib/python3.6/site-packages/prompt_toolkit/eventloop/utils.py", line 69, in schedule
if not loop2._ready: # type: ignore
Press ENTER to continue...
...(etc)
I haven't had a chance to hunt down if we have another fix for it, so
for now I'm treating it like an ipython bug. Once attach works,
we can relax ipython versions again.
More discussion here:
ethereum#1343
|
Closed #1312 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
A bug in the Istanbul implementation is in the pinned version of py-evm.
How was it fixed?
Upgrade py-evm to latest version which fixes the bug:
https://py-evm.readthedocs.io/en/latest/release_notes.html#py-evm-0-3-0-alpha-9-2019-12-02
To-Do
Cute Animal Picture