Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Cleaner txpool shutdown #1356

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Conversation

carver
Copy link
Contributor

@carver carver commented Dec 5, 2019

What was wrong?

The transaction pool was hanging on shutdown, because it had a bare await that doesn't get cancelled when the service is cancelled.

This shows up in an INFO log as:

Timed out waiting for <...TxPool...> to finish its cleanup, forcibly cancelling pending tasks and exiting anyway

How was it fixed?

Added a couple self.wait()s. Now that log doesn't show up anymore, and the shutdown is a bit faster.

Bonus changes:

To-Do

  • Clean up commit history

Cute Animal Picture

put a cute animal picture link inside the parentheses

@carver carver requested a review from cburgdorf December 5, 2019 01:17
@carver
Copy link
Contributor Author

carver commented Dec 5, 2019

Is there any chance #1362 is related to this PR? It seems unlikely, but wanted to get more 👀 on it from @cburgdorf before merging.

@carver
Copy link
Contributor Author

carver commented Dec 5, 2019

#1362 Seems very unlikely to be related to this, since #1354 has the same error in CI.

So I'll go ahead and rage-merge this.

@carver carver merged commit dd440fa into ethereum:master Dec 5, 2019
@carver carver deleted the cleaner-txpool-shutdown branch December 5, 2019 23:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants