This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Mysterious spontaneous linter issues #1357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have no idea why these just showed up. The mypy version (and mypy-extensions) didn't change. It first showed up in a version bump that didn't change any code. Surprises make me grumpy. (Also couldn't reproduce the errors anywhere besides tox, mypy passes in local runs) Luckily the fixes were straightforward, and I don't *disagree* with the lines that they are wrong (except serialization_codec needing an explicit type, which seems odd).
carver
changed the title
cburgdorf
approved these changes
Dec 5, 2019
|
Merged this because it unbreaks CI for everyone. |
carver
added a commit
to carver/trinity
that referenced
this pull request
Dec 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why these just showed up. The mypy version (and
mypy-extensions) didn't change.
It first showed up in a version bump that didn't change any code.
Surprises make me grumpy. (Also couldn't reproduce the errors anywhere
besides tox, mypy passes in local runs)
Luckily the fixes were straightforward, and I don't disagree with the
lines that they are wrong (except serialization_codec needing an
explicit type, which seems odd).
To-Do
Cute Animal Picture