This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Install RLP rust backend explicitly #2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still depending on a cascade of other releases (see ethereum/py-trie#119) |
cburgdorf
force-pushed
the
christoph/chore/rlp-rust-backend
branch
from
fc052a0
to
135325f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
rlp 2.0.0a1came with a fix dependency against a binary library written in Rust. Unfortunately, the supported binaries leave some platforms unsupported (all 32 bit, ARM etc). A new versionrlp 2.0.0a2addresses that by making the rust backend entirely optional. That in turn means it has to be enabled explicitly on an application level (e.g. Trinity).How was it fixed?
Added dependency against
"rlp[rust-backend]>=2.0.0-alpha.2, <3"To-Do
Cute Animal Picture