This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Implement per-block processing - eth1 data #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
changed the title
hwwhww
approved these changes
Feb 3, 2019
| (index, eth1_data_vote) | ||
| for index, eth1_data_vote in enumerate(state.eth1_data_votes) | ||
| if block.eth1_data == eth1_data_vote.eth1_data | ||
| ) |
There was a problem hiding this comment.
Oh, this try, except StopIteration, else pattern looks interesting to me! But since ethereum/consensus-specs#561 clarified ethereum/consensus-specs#555 and using first makes us lose the advantage of that we can break the for-loop earlier once we find block.eth1_data == eth1_data_vote.eth1_data. IMHO I think the formal boring for-if-break is better in this case now.
There was a problem hiding this comment.
First will also break early as it's given a generator instead of a list.
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
eth1 data processing was missing
How was it fixed?
Implemented it
Cute Animal Picture