This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Introducing Node for py-libp2p
#795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhchia
force-pushed
the
feature/pylibp2p-node
branch
from
b40c001
to
3d53534
Compare
9 tasks
mhchia
force-pushed
the
feature/pylibp2p-node
branch
from
ed1f54e
to
b1b9bd3
Compare
|
Will fix the CI tomorrow and this PR should be ready by the time. 🙏 |
mhchia
force-pushed
the
feature/pylibp2p-node
branch
from
7dd08b6
to
3311c2f
Compare
mhchia
changed the title
Node for py-libp2pNode for py-libp2p
|
Should be ready now. |
This was referenced Jul 17, 2019
To avoid package name conflicts with py-libp2p
Along with - configs.py: configs for libp2p protocols standard - utils.py: identity generation and protocol id helpers for now - And the incomplete tests
- Add `Node` service. - Add tests for `dial_peer`.
Generate the testing nodes with the factory.
- Add `NodeFactory.create_batch` - Add `try/finally` to the fixture `nodes` to ensure nodes are close even when the generator is closed
And modify tox.ini
Along with the deps in setup.py
mhchia
force-pushed
the
feature/pylibp2p-node
branch
from
a24c445
to
2dc564c
Compare
NIC619
approved these changes
Jul 20, 2019
| muxer_opt=muxer_protocol_ids, | ||
| sec_opt=security_protocol_ops, | ||
| peerstore_opt=None, # let the function initialize it | ||
| disc_opt=None, # no routing required here |
There was a problem hiding this comment.
Question: is this a temporary thing?
There was a problem hiding this comment.
I think it will be used for a while because we will use discv5 instead of the Kademlia in libp2p for the discovery.
|
|
||
| MULTIPLEXING_PROTOCOL_ID = "/mplex/6.7.0" | ||
|
|
||
| PUBSUB_PROTOCOL_ID = "/eth/serenity/gossipsub/1.0.0" |
There was a problem hiding this comment.
Should this be GOSSIPSUB_PROTOCOL_ID?
There was a problem hiding this comment.
I actually mean "the protocol id of pubsub we use here". Given this context, does PUBSUB_PROTOCOL_ID make sense?
tests/libp2p/bcc/test_node.py
Outdated
| ) | ||
| assert nodes[0].peer_id in nodes[1].host.get_network().connections | ||
| assert nodes[1].peer_id in nodes[0].host.get_network().connections | ||
| # Test: Reuse the old connection when connecting again |
There was a problem hiding this comment.
nit: The wording here sounds like it is reconnecting after disconnecting. What about
# Test: Second dial to a connected peer does not open a new connection
- Change `PUBSUB_PROTOCOL_ID` to `GOSSIPSUB_PROTOCOL_ID` - Reword the description of a test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
libp2pconflicts with the dependency libp2p/py-libp2p.How was it fixed?
Nodeto contain the components in py-libp2p we need.To-Do
Node.Cute Animal Picture