Release - 1.2.1

[nivida]

Description

This release contains mostly compatibility fixes for Windows and nodejs.

Fixed

• websocket dependency fixed (Can't install web3 version 1.2 on Windows 10 #2971, switch repo fork for the websocket package #2976)
• Node >= v8.0.0 support (Node >= v8.0.0 support for web3 1.0 #2938)

Added

• requestOptions added to WebsocketProvider (requestOptions support added #2979)

Compare View

v1.2.0 -> v1.2.1

Type of change

• Release

Checklist:

• I have selected the correct base branch.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation.
• My changes generate no warnings.
• I have updated or added types for all modules I've changed
• Any dependent changes have been merged and published in downstream modules.
• I ran npm run test in the root folder with success and extended the tests to cover all changes.
• I ran npm run build in the root folder and tested it in the browser and with node.
• I have tested my code with an ethereum test network.

[coveralls]

Coverage remained the same at 83.191% when pulling a3264cd on release/1.2.1 into 21359d0 on 1.x.

[spalladino]

Looks good @nivida, thanks for tackling this! Do you want to release this in the beta/rc/next channel, so we can run it on OpenZeppelin/Buidler/Truffle/Embark to see how it goes?

[michaelsbradleyjr]

Looks good, only additional things I would note:

#2938 also includes the "Encryption of the V3Keystore fixed" as noted in the 2.0.0-alpha.1 release PR for #2950.

Starting with #2938, for Node versions <10.5.0 there will be a warning displayed in the console re: (deprecated) scrypt needing to be installed to improve performance; that warning will always be displayed at runtime when require('web3') is called the first time unless the deprecated scrypt package has already been installed in the user's project.

[nivida]

Looks good @nivida, thanks for tackling this! Do you want to release this in the beta/rc/next channel, so we can run it on OpenZeppelin/Buidler/Truffle/Embark to see how it goes?

@gnidan was able to run the tests without a rc release and I think it isn't required to release a rc version of it because we discussed and tested it already closely. But I see the point of doing a rc release if there are bigger changes.

#2938 also includes the "Encryption of the V3Keystore fixed" as noted in the 2.0.0-alpha.1 release PR for #2950.

I will add it to the changelog and will explain the behaviour in the release announcement. Thanks for providing these fixes @michaelsbradleyjr!

Version 1.2.1 will get released tomorrow (CEST).

[gnidan]

I was able to run Truffle's CI against web3 git clone, but it's really inconvenient >___<. Would be much nicer if we could make a process for rc releases in the future!