Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supportsSubscriptions method added to providers #3116

Merged
merged 3 commits into from
Oct 8, 2019
Merged

supportsSubscriptions method added to providers #3116

merged 3 commits into from
Oct 8, 2019

Conversation

nivida
Copy link
Contributor

@nivida nivida commented Oct 8, 2019

back-porting of #2632 from 2.x to 1.x

@nivida nivida added Enhancement Includes improvements or optimizations In Progress Currently being worked on 1.x 1.0 related issues labels Oct 8, 2019
@coveralls
Copy link

coveralls commented Oct 8, 2019

Coverage Status

Coverage decreased (-0.08%) to 83.067% when pulling a5fa01f on issue/1015 into 8840209 on 1.x.

@nivida nivida removed the In Progress Currently being worked on label Oct 8, 2019
@nivida nivida merged commit 9a13b32 into 1.x Oct 8, 2019
@nivida
Copy link
Contributor Author

nivida commented Oct 8, 2019

The documentation for all providers will get improved with issue #3117

@nivida nivida deleted the issue/1015 branch October 11, 2019 09:17
@nivida nivida mentioned this pull request Oct 21, 2019
11 tasks
@alcuadrado
Copy link

I wouldn't release this just yet. It would expose a super experimental API that will probably change soon.

@cgewecke
Copy link
Collaborator

It would expose a super experimental API that will probably change soon.

@alcuadrado

Could you elaborate your view of this? It's experimental wrt EIP 1193 & the Events Spec?

@alcuadrado
Copy link

Yes, sure. We had a meeting with about ~15 people to discuss the direction of the EIP-1193 during devcon. I'll post a summary and several PRs soon. One of the conclusions was that the provider should describe its capabilities. We explored many possible solutions, including not doing them at all, using a bunch of boolean fields, a supports function, and a supports object.

IMO the EIP should be updated to reflect that, and some consensus is reached, implemented here.

@cgewecke
Copy link
Collaborator

@alcuadrado Ah! Excellent thanks.

@nivida
Copy link
Contributor Author

nivida commented Oct 22, 2019

Yes, sure. We had a meeting with about ~15 people to discuss the direction of the EIP-1193 during devcon. I'll post a summary and several PRs soon. One of the conclusions was that the provider should describe its capabilities. We explored many possible solutions, including not doing them at all, using a bunch of boolean fields, a supports function, and a supports object.

IMO the EIP should be updated to reflect that, and some consensus is reached, implemented here.

@alcuadrado This is true but it will take an amount of time until this EIP is finalized and the method supportsSubscriptions is a long out-standing and simple feature request from the community. It is additionally allowed to extend an existing EIP as long as we support all the functionalities this EIP does define. I mean with this that we currently can keep this method until the EIP-1193 is finalized and we can later provide compatibility to the EIP-1193. If the method getCapabilities(): Capabilities got added. Will supportsSubscription first be a wrapper of the existing getCapabilities method just with a deprecation message added and can get removed later with a Minor release of web3.js.

@alcuadrado
Copy link

alcuadrado commented Oct 22, 2019 via email

nachomazzara pushed a commit to nachomazzara/web3.js that referenced this pull request Jun 4, 2020
* supportsSubscriptions method added to providers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues Enhancement Includes improvements or optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants