Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bundlesize ci check for PRs from forks #3626

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Fix bundlesize ci check for PRs from forks #3626

merged 1 commit into from
Jul 7, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented Jul 7, 2020

Description

In #3622, the bundlesize cmd is failing with: (link)

> web3.js@ bundlesize /home/runner/work/web3.js/web3.js
> bundlesize

 ERROR  Could not add github status.
        403: Resource not accessible by integration

I believe this issue is related to the PR originating from an external fork.

This PR is a quick fix to resolve the issue so PRs from forks do not fail the ci lint check.

@ryanio ryanio added 1.x 1.0 related issues CI labels Jul 7, 2020
@ryanio
Copy link
Collaborator Author

ryanio commented Jul 7, 2020

I opened an issue on the bundlesize repository here: siddharthkp/bundlesize#363

@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited

Coverage Status

Coverage remained the same at 90.166% when pulling d8d020a on fix-bundlesize-from-forks into 4e36583 on 1.x.

@cgewecke cgewecke self-requested a review July 7, 2020 23:28
cgewecke
cgewecke approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 💯

@ryanio ryanio merged commit ce9ac7b into 1.x Jul 7, 2020
@GregTheGreek GregTheGreek deleted the fix-bundlesize-from-forks branch July 26, 2020 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryanio @coveralls @cgewecke