Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for isHex and isHexStrict. #3622

Merged
merged 4 commits into from
Jul 13, 2020
Merged

Add unit tests for isHex and isHexStrict. #3622

merged 4 commits into from
Jul 13, 2020

Conversation

andrew-m-higgs
Copy link
Contributor

Description

Added unit tests for isHex and isHexStrict.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.

@coveralls
Copy link

coveralls commented Jul 7, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 90.254% when pulling 8b7f560 on andrew-m-higgs:issue/3615 into 6ee7118 on ethereum:1.x.

@ryanio ryanio added 1.x 1.0 related issues Testing labels Jul 7, 2020
@andrew-m-higgs andrew-m-higgs reopened this Jul 7, 2020
@ryanio ryanio mentioned this pull request Jul 7, 2020
Merged
ryanio
ryanio approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@GregTheGreek GregTheGreek merged commit 6862c59 into web3:1.x Jul 13, 2020
@ryanio ryanio mentioned this pull request Jul 18, 2020
Merged
14 tasks
ryanio added a commit that referenced this pull request Jul 18, 2020
@ryanio
add #3622 to changelog
88df88d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregTheGreek GregTheGreek GregTheGreek approved these changes

@ryanio ryanio ryanio approved these changes

Assignees
No one assigned
Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrew-m-higgs @coveralls @ryanio @GregTheGreek