Use UTS46 domain name processing, not full IDNA processing #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carver From what I can tell, this stills works how it was intended, but I would appreciate your 👀to be sure. And, are there other test cases I should consider? Edit: shoulda waited until all the tests passed before I pinged you, sorry. Let me know if you think there are any test cases outside of the currently failing specs I should consider. |
kclowes
changed the title
|
Nothing more to add, except there is a lot of room to improve the test suite of nameprep. I wouldn't assume that green means that everything is great. It's worth looking around to find a nice full set of fixtures to test against. |
carver
reviewed
May 24, 2019
carver
reviewed
May 24, 2019
kclowes
changed the title
kclowes
force-pushed
the
1358-no-idna-processing
branch
from
a25ad92
to
90af64d
Compare
kclowes
changed the title
pipermerriam
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
web3py was doing full IDNA processing, instead of UTS46.
Related to Issue #1358 and #1357
How was it fixed?
Added some emoji and other test cases that are valid according to UTS46 but not IDNA2008 to make sure they are
nameprepped correctly.Cute Animal Picture