Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updated GethPersonal to snake_case #1470

Open
wants to merge 1 commit into
base: master
from

Conversation

@smilegodly
Copy link

smilegodly commented Oct 12, 2019

What was wrong?

GethPersonal module needed to use snake_case names for JSON-RPC methods.
Related to Issue #1429

How was it fixed?

Added deprecation warnings to the old method tests in GethPersonal class , added new snake_case methods to said class, added methods to the eth-tester, updated GethPersonal rst file in the docs.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@smilegodly smilegodly force-pushed the smilegodly:change_method_casings branch from 8eb0524 to 6604a48 Oct 14, 2019
@smilegodly smilegodly changed the title Updated GethPersonal to snake_case Updated GethPersonal to snake_case [WIP] Oct 15, 2019
@smilegodly smilegodly changed the title Updated GethPersonal to snake_case [WIP] [WIP] Updated GethPersonal to snake_case Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.