[WIP] Updated GethPersonal to snake_case #1470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilegodly
force-pushed
the
change_method_casings
branch
from
8eb0524
to
6604a48
Compare
smilegodly
changed the title
smilegodly
changed the title
|
Thank you for taking the time to submit a PR @smilegodly! Closing this in favor of #1589. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
GethPersonal module needed to use snake_case names for JSON-RPC methods.
Related to Issue #1429
How was it fixed?
Added deprecation warnings to the old method tests in GethPersonal class , added new snake_case methods to said class, added methods to the eth-tester, updated GethPersonal rst file in the docs.
Cute Animal Picture