fixed deprecation warning #1474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Lohr <mail@mlohr.com>
kclowes
approved these changes
Oct 18, 2019
|
What about updating the release notes? How can we get this merged (and released) as soon as possible? |
|
@MatthiasLohr see https://github.com/ethereum/web3.py/blob/3070f894df633b8f27551db6f3e22ef0667c24e0/newsfragments/README.md for release notes update procedure. |
|
Just updated the release note @MatthiasLohr. I'll merge and release today. |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#1468 was a great Pull Request to fix deprecation warnings. However, I think they missed something.
How was it fixed?
Searching for
privateKeyToAccountin the whole project and replaced withfrom_key. One single match, which causes deprecation warnings in my project.Todo:
Cute Animal Picture