Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/ipc: fix Trinity IPC path to include 'ipcs-eth1' sub-dir #1563

Merged
merged 2 commits into from Jan 8, 2020

Conversation

@veox
Copy link
Contributor

veox commented Jan 8, 2020

What was wrong?

Trinity's jsonrpc.ipc socket has moved to a sub-dir quite some time ago. I believe the change was made in ethereum/trinity#8, >1y ago, and landed in trinity-v0.1.0-alpha.21.

This has not been updated (or documented), probably because Trinity's JSON-RPC support is still limited.

How was it fixed?

Point towards the new socket location now, and mention the fact in docs.

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Source: satinek@Pixabay

veox added 2 commits Jan 8, 2020
Trinity's `jsonrpc.ipc` socket has moved to a sub-dir quite some
time ago. This has not been updated (or documented), probably
because Trinity's JSON-RPC support is still limited.

Anyway, point towards the new socket location now, and mention
the fact in docs.
@@ -100,7 +100,7 @@ def get_default_ipc_path() -> str: # type: ignore
return ipc_path

base_trinity_path = Path('~').expanduser() / '.local' / 'share' / 'trinity'
ipc_path = str(base_trinity_path / 'mainnet' / 'jsonrpc.ipc')

This comment has been minimized.

Copy link
@veox

veox Jan 8, 2020

Author Contributor

Question: should this perhaps remain, for compatibility with very old versions of Trinity?

It's also "technically" a backwards-incompatible change. I'm not sure web3.py would even work with versions that old, TBH; haven't checked.

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Jan 8, 2020

Member

No, at this point we're still in alpha and no need to preserve support for old versions since this can be done manually if people really need to connect to an old version.

@veox veox changed the title [WIP] providers/ipc: fix Trinity IPC path to include 'ipcs-eth1' sub-dir providers/ipc: fix Trinity IPC path to include 'ipcs-eth1' sub-dir Jan 8, 2020
@pipermerriam

This comment has been minimized.

Copy link
Member

pipermerriam commented Jan 8, 2020

Maybe backport to v4 if you're feeling ambitious @kclowes

@kclowes kclowes merged commit b50d616 into ethereum:master Jan 8, 2020
42 checks passed
42 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-ens Your tests passed on CircleCI!
Details
ci/circleci: py36-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-ens Your tests passed on CircleCI!
Details
ci/circleci: py37-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py38-core Your tests passed on CircleCI!
Details
ci/circleci: py38-ens Your tests passed on CircleCI!
Details
ci/circleci: py38-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-parity-ws Your tests passed on CircleCI!
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.