providers/ipc: fix Trinity IPC path to include 'ipcs-eth1' sub-dir #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trinity's `jsonrpc.ipc` socket has moved to a sub-dir quite some time ago. This has not been updated (or documented), probably because Trinity's JSON-RPC support is still limited. Anyway, point towards the new socket location now, and mention the fact in docs.
veox
commented
Jan 8, 2020
| @@ -100,7 +100,7 @@ def get_default_ipc_path() -> str: # type: ignore | |||
| return ipc_path | |||
|
|
|||
| base_trinity_path = Path('~').expanduser() / '.local' / 'share' / 'trinity' | |||
| ipc_path = str(base_trinity_path / 'mainnet' / 'jsonrpc.ipc') | |||
There was a problem hiding this comment.
Question: should this perhaps remain, for compatibility with very old versions of Trinity?
It's also "technically" a backwards-incompatible change. I'm not sure web3.py would even work with versions that old, TBH; haven't checked.
There was a problem hiding this comment.
No, at this point we're still in alpha and no need to preserve support for old versions since this can be done manually if people really need to connect to an old version.
veox
changed the title
pipermerriam
approved these changes
Jan 8, 2020
|
Maybe backport to v4 if you're feeling ambitious @kclowes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Trinity's
jsonrpc.ipcsocket has moved to a sub-dir quite some time ago. I believe the change was made in ethereum/trinity#8, >1y ago, and landed intrinity-v0.1.0-alpha.21.This has not been updated (or documented), probably because Trinity's JSON-RPC support is still limited.
How was it fixed?
Point towards the new socket location now, and mention the fact in docs.
Todo:
Cute Animal Picture
Source: satinek@Pixabay