Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new Net module snake-case properties #1581

Conversation

billbsing
Copy link
Contributor

What was wrong?

Related to Issue #1429

How was it fixed?

Changed the properties of the net module to snake-case

Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @billbsing! This is looking good!

web3/net.py Outdated Show resolved Hide resolved
web3/providers/eth_tester/defaults.py Outdated Show resolved Hide resolved
@billbsing billbsing changed the title add new snake-case properties add new Net module snake-case properties Feb 24, 2020
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @billbsing!

@kclowes kclowes force-pushed the billbsing/add-net-module-properties-to-snake-case branch from c516912 to 917cce1 Compare February 24, 2020 16:17
@kclowes kclowes merged commit 9628632 into ethereum:master Feb 24, 2020
@billbsing billbsing deleted the billbsing/add-net-module-properties-to-snake-case branch March 9, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants