Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Providers context docs #1619

Merged
merged 1 commit into from
Mar 31, 2020
Merged

improve Providers context docs #1619

merged 1 commit into from
Mar 31, 2020

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Mar 31, 2020

What was wrong?

Closes #1609

  • moves Providers, Examples, and Troubleshooting up in the docs table of contents
  • provides some additional context about Providers in the Quickstart and Troubleshooting pages.

Todo:

Cute Animal Picture

@wolovim wolovim mentioned this pull request Mar 31, 2020
Closed
kclowes
kclowes approved these changes Mar 31, 2020
View reviewed changes
Copy link
Collaborator

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @marcgarreau! 🚢

docs/quickstart.rst
`Infura <https://infura.io/>`_. On Infura, create a project and copy
the Project ID. Then set the environment variable ``WEB3_INFURA_PROJECT_ID``.
There are several ways to configure this connection; the
full details can be found in the :ref:`Providers<providers>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wolovim wolovim merged commit c852b8c into ethereum:master Mar 31, 2020
@wolovim wolovim deleted the provider-docs-tweaks branch March 31, 2020 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kclowes kclowes kclowes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better document how to set up a web3 instance
2 participants
@wolovim @kclowes