Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate getFilterChanges in favor of get_filter_changes #1916

Merged

Conversation

tmckenzie51
Copy link
Contributor

@tmckenzie51 tmckenzie51 commented Mar 17, 2021

What was wrong?

Added get_filter_changes, deprecated getFilterChanges

Related to Issue #1429

Todo:

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@tmckenzie51 tmckenzie51 force-pushed the tiffany/getFilterChanges-to-snakecase branch from 2dad949 to 3973f03 Compare March 22, 2021 20:38
@tmckenzie51 tmckenzie51 changed the title Tiffany/get filter changes to snakecase deprecate getFilterChanges in favor of get_filter_changes Mar 25, 2021
@tmckenzie51 tmckenzie51 force-pushed the tiffany/getFilterChanges-to-snakecase branch from fb75a35 to 1b52fd9 Compare March 25, 2021 19:23
@kclowes
Copy link
Collaborator

kclowes commented Mar 31, 2021

Looks like you missed a few getFilterChanges in this one. You can see by opening the py36-core tests and looking at the 'Run Tox' output. There are a bunch of DeprecationWarnings at the top of the warnings summary output. I did some manual testing and that looks good though!

@kclowes kclowes force-pushed the tiffany/getFilterChanges-to-snakecase branch from 74810a8 to 40e4f6c Compare April 5, 2021 21:06
@kclowes kclowes merged commit fe61b38 into ethereum:master Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants