set maxFeePerGas if not provided #2055
Conversation
| max_fee_per_gas = priority_fee + 2 * base_fee | ||
| transaction = assoc(transaction, 'maxFeePerGas', hex(max_fee_per_gas)) | ||
| return make_request(method, [transaction]) | ||
| except Exception: |
There was a problem hiding this comment.
When would we be unable to calculate maxFeePerGas? This except Exception seems pretty broad - I wonder if we could narrow it down some?
| priority_fee = int(transaction['maxPriorityFeePerGas'], 16) | ||
| max_fee_per_gas = priority_fee + 2 * base_fee | ||
| transaction = assoc(transaction, 'maxFeePerGas', hex(max_fee_per_gas)) | ||
| return make_request(method, [transaction]) |
There was a problem hiding this comment.
@marcgarreau If we fail at the make_request call, we will have already added the maxFeePerGas field to the transaction, based on the line:
transaction = assoc(transaction, 'maxFeePerGas', hex(max_fee_per_gas))
We should probably make sure we've removed that field [the maxPriorityFeePerGas] at the except block, otherwise we will ultimately be making the same call that we did in the try block.
We can have a test case for this with an alphabetical string as the value for maxPriorityFeePerGas to make sure the try block fails. This test should fail... but if we add transaction.pop('maxPriorityFeePerGas') in the except block, it should pass.
There was a problem hiding this comment.
Correction on the above... I don't think we can actually catch any exception from the make_request call since it feeds back to this method and it will now have both params.
If we fail, it will be because the maxPriorityFeePerGas is invalid and therefore that is what we should pop in the except block. I will edit the above comment.
There was a problem hiding this comment.
So by just putting the 2 wei on the max priority fee solves it?
Is this really optimal solution?
What was wrong?
One of the 1559 TODOs was to determine an appropriate
maxFeePerGasif one was not provided, but amaxPriorityFeePerGaswas. (Related to #2054)How was it fixed?
This follows Geth's behavior to set the
maxFeePerGastomaxPriorityFeePerGas + 2*baseFee.Todo:
Cute Animal Picture