Issue 2040 #2209
Issue 2040 #2209
Conversation
fselmo
force-pushed
the
issue-2040
branch
4 times, most recently
from
ad945df
to
36e5d1a
Compare
fselmo
force-pushed
the
issue-2040
branch
2 times, most recently
from
0245908
to
6832b83
Compare
| @@ -617,7 +617,8 @@ The following methods are available on the ``web3.eth`` namespace. | |||
| ``eth_getTransactionByBlockNumberAndIndex`` if ``block_identifier`` is an | |||
| integer or one of the predefined block parameters ``'latest', 'earliest', | |||
| 'pending'``, otherwise delegates to | |||
| ``eth_getTransactionByBlockHashAndIndex``. If the transaction has not yet been mined throws :class:`web3.exceptions.TransactionNotFound`. | |||
| ``eth_getTransactionByBlockHashAndIndex``. | |||
| If a transaction is not found at specified arguments, throws :class:`web3.exceptions.TransactionNotFound`. | |||
There was a problem hiding this comment.
This change is important because this method does return a transaction for pending blocks; i.e. not-yet-mined transactions.
e.g. get_transaction_by_block('pending', txn_index)
|
@dshehbaj, @shreyassai123, @DavidRomanovizc thanks for all the work on this! I saw there were 3 open PRs with very similar changes. I tried to piggy back off of them here and give credit to all 3 😃 My changes were rebasing with the current |
There was a problem hiding this comment.
Awesome! Thanks @fselmo, @dshehbaj, @shreyassai123, and @DavidRomanovizc! LGTM! 🚢
credit: @dshehbaj, @shreyassai123, @DavidRomanovizc commit summary: - Defined RPC methods in rpc_abi.py - Defined eth.get_raw_transaction_by_block method - Method formatting - Suggested changes - Linting - Fixed Errors
- Reconcile differences across all 3 getRawTransactionByBlock PRs - Add tests - Minor corrections for eth_getRawTransactionByBlock - Add docs
with pleasure |
What was wrong?
Related to:
How was it fixed?
Todo:
Cute Animal Picture