Spurious Dragon: EIP155 replay protection #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this change also affect ECDSARECOVER precompiled contract? |
|
No, that did not happen. |
|
maybe it should be noted in the yellow paper because this PR changes definition of ECDSARECOVER which is also used (I mean the name) in precompiled contract section |
|
I begin to see what you mean. Let me investigate. |
|
I confirm that this PR changes the definition of |
|
I can also confirm that in |
|
This PR should normalize the value of |
pirapira
changed the title
pirapira
force-pushed
the
eip155_replay_prevention
branch
from
0aa23f8
to
d8b6d41
Compare
|
This PR should target the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows ethereum/EIPs#155 as part of the Spurious Dragon changes.
Since I've branched
homestead, and this change has already been taken into the mainnet, this PR is onmaster.