Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Clean Up on ecip-1049.md #400

Merged
merged 7 commits into from
Feb 9, 2021
Merged

Conversation

gitr0n1n
Copy link
Contributor

@gitr0n1n gitr0n1n commented Dec 3, 2020

  • move to Draft Status (Expired Last Call Review on Oct 9, 2020) due to material redraft of proposal.
  • Update Discussion Thread to new Redraft thread
  • Add Related Discussions Section for archived threads

gitr0n1n and others added 3 commits December 3, 2020 16:54
+ move to Draft Status (Expired Last Call Review on Oct 9, 2020) due to material redraft of proposal.
+ Update Discussion Thread to new Redraft thread
+ Related Discussions Section
ECIP Process Formality:
+ Move to Rejected after failing in Last Call by Ot 9, 2020.
@q9f q9f added editor:5 needs-review This contribution needs a careful review. status:5 last-call ECIP has been accepted and is waiting for last-call reviews. type: std-core ECIPs of the type "Core" - changing the Classic protocol. labels Dec 4, 2020
@q9f
Copy link
Contributor

q9f commented Dec 4, 2020

I think we can continue working on that document, so I would rather send it back to draft status rather than rejecting it.

@gitr0n1n
Copy link
Contributor Author

gitr0n1n commented Dec 5, 2020

I think we can continue working on that document, so I would rather send it back to draft status rather than rejecting it.

Can that direct movement to Draft be made? source: the ECIP diagram.

I see that Last Call status can only be moved to Accepted or Rejected.

Last Call - An ECIP that is done with its initial iteration and ready for review by a wider audience.
https://github.com/ethereumclassic/ECIPs/raw/master/assets/ecip-1000/process.png

Pedantic, but thats how the Editors have chosen to follow the ECIP process for all ECIPs.

So move ECIP-1049 to Rejected. Alex resubmits the materially changed reDraft proposal to Draft status. Will that require a new ECIP # (like all the Aztlan proposals)? @q9f I think if we did that, it would accomplish the end goal of getting Alex's new proposal back to draft status for review. The new ECIP # aligns with the desire for a new discussion thread as well.

Regardless, I agree with you that it should END in draft status. However you think that should happen.

@ethereumclassic ethereumclassic deleted a comment Dec 8, 2020
@gitr0n1n
Copy link
Contributor Author

gitr0n1n commented Jan 19, 2021

I think we can continue working on that document, so I would rather send it back to draft status rather than rejecting it.

@q9f can we get this ECIP moved back to the status it is currently in: Draft.

I believe we might needed to have it Withdrawn then resubmitted as Draft. The issue is that this proposal has past its current review period and now the authors are re-drafting the proposal. It's almost been in this limbo state for 60 days. I think its time to clean this up. I'd do it myself if I was an editor, but those PRs are also sitting on the shelf.

Thanks in advance for the ECIP housekeeping.

@q9f
Copy link
Contributor

q9f commented Feb 1, 2021

I would supporting moving it back to Draft for the time being

@bobsummerwill
Copy link
Member

That would make sense to me too, @q9f.

The flow chart in ECIP-1000 does not show a path from Last Call back to Draft, but I don't think we gain anything by forcing the creation of a new, identical ECIP just for the sake of rigid adherence.

@ghost
Copy link

ghost commented Feb 3, 2021

@gitr0n1n @q9f @bobsummerwill ECIPs can perfectly be moved back to draft. The ECIP process does not specifically say that it can't and the drawing is just a diagram. I drew it like that cause I was copying the Bitcoin one (see below) and for some reason put arrows instead of just lines. I guess I unconsciously put arrows as I was thinking in the forward process, and not about special cases where ECIPs needed to go backward.

bip-process

The ECIP process has predecessors in the BIP and EIP processes. EIP says clearly:

Last Call - This is the final review window for an EIP before moving to FINAL. An EIP editor will assign Last Call status and set a review end date (review-period-end), typically 14 days later.

If this period results in necessary normative changes it will revert the EIP to REVIEW.

Final - This EIP represents the final standard. A Final EIP exists in a state of finality and should only be updated to correct errata and add non-normative clarifications.

Stagnant - Any EIP in DRAFT or REVIEW if inactive for a period of 6 months or greater is moved to STAGNANT. An EIP may be resurrected from this state by Authors or EIP Editors through moving it back to DRAFT.

BIP say clearly:

BIPs should be changed from Draft or Proposed status, to Rejected status, upon request by any person, if they have not made progress in three years. Such a BIP may be changed to Draft status if the champion provides revisions that meaningfully address public criticism of the proposal, or to Proposed status if it meets the criteria required as described in the previous paragraph.

I tried to change the diagram when Wei Tang was harassing the ETC ecosystem arguing the same thing about no backward status changes. The supposed impossibility of moving ECIPs backward to draft was always false, because it is obvious that when an ECIP has a catastrophic problem, no matter what is the status, they have to be moved back to draft to correct issues (as prescribed by the BIP and EIP).

This has happened in ETH, but I don't remember what case it was.

In conclusion, ECIPs can be moved to draft (I co-wrote ECIP-1000). I will enter the corrected diagram to the assets folder so it is corrected and does not create these confusions again.

Wei was controlling the ECIP-1000 repo at the time of the argument and constantly sabotaging other ECIPs and commentary as he had editor, writing, and author access and authority. That is why I could never change the diagram.

@ghost
Copy link

ghost commented Feb 3, 2021

@gitr0n1n @q9f @bobsummerwill

This is the correct diagram for ECIP-1000:

process

...but I think I messed up when creating the PR from my fork (I haven't used GitHub for a long time ;)

could one of you add the process.png image to the assets folder pls?

Note that the diagram above is the new correct one, the previous one was not even updated to all the possible statuses that ECIPs may have.

_specs/ecip-1049.md Outdated Show resolved Hide resolved
Move to `Draft` status based on the feedback from the Core Devs Call 15 and a material redraft of the proposal by the authors. The direct move to `Draft` is suggested by Donald McIntyre, ETC Coop employees, and other propoenents of the ECIP via the comments of this PR.
@gitr0n1n
Copy link
Contributor Author

gitr0n1n commented Feb 5, 2021

@gitr0n1n @q9f @bobsummerwill

This is the correct diagram for ECIP-1000:

process

...but I think I messed up when creating the PR from my fork (I haven't used GitHub for a long time ;)

could one of you add the process.png image to the assets folder pls?

Note that the diagram above is the new correct one, the previous one was not even updated to all the possible statuses that ECIPs may have.

Thanks for clarifying that diagram.

@ghost
Copy link

ghost commented Feb 5, 2021

@gitr0n1n I just re-learned how to use GitHub....lol....so I entered a PR to update the diagram.

@bobsummerwill
Copy link
Member

Wei must have polluted my brain with his rigidity about the process, @tokenhash!

@q9f
Copy link
Contributor

q9f commented Feb 9, 2021

Thanks!

@q9f q9f merged commit 5d8b523 into ethereumclassic:master Feb 9, 2021
@gitr0n1n gitr0n1n deleted the draft-ecip-1049 branch February 9, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor:5 needs-review This contribution needs a careful review. status:5 last-call ECIP has been accepted and is waiting for last-call reviews. type: std-core ECIPs of the type "Core" - changing the Classic protocol.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants