Skip to content
This repository has been archived by the owner on Apr 6, 2020. It is now read-only.

Replace uses of deprecated new Buffer with Buffer.from #80

Merged
merged 1 commit into from
Dec 7, 2018

Conversation

whymarrh
Copy link
Contributor

@whymarrh whymarrh commented Dec 7, 2018

new Buffer(string [, encoding]) is deprecated and this PR replaces the usages of it with Buffer.from(string [, encoding]). It's been deprecated since Node v6, which is the earliest version we run CI using.

Copy link
Contributor

@vpulim vpulim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Buffer already uses safe-buffer, so these lines were probably missed.

@whymarrh whymarrh merged commit de0230d into ethereumjs:master Dec 7, 2018
@whymarrh whymarrh deleted the new-buffer branch December 7, 2018 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants