Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Add rpc method eth_blockNumber #131

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Add rpc method eth_blockNumber #131

merged 1 commit into from
Jun 11, 2020

Conversation

tomonari-t
Copy link
Contributor

@tomonari-t tomonari-t commented Jun 10, 2020 •
edited
Loading

@coveralls
Copy link

coveralls commented Jun 10, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 92.575% when pulling 60ea7f9 on rpc-method-get-block-number into f7c810e on master.

holgerd77
holgerd77 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomonari-t, this looks good, will merge! 😄

test/rpc/helpers.js
@@ -54,7 +54,7 @@ module.exports = {
return server
},

params (method, params) {
params (method, params = []) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good addition, with the default array initialization.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@holgerd77 holgerd77 merged commit 0a9e03e into master Jun 11, 2020
@holgerd77 holgerd77 deleted the rpc-method-get-block-number branch June 11, 2020 07:27
@tomonari-t tomonari-t mentioned this pull request Jun 20, 2020
Merged
holgerd77 added a commit that referenced this pull request Jun 20, 2020
@holgerd77
Added PR #131 to CHANGELOG
12df250
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
PR state: needs review type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomonari-t @coveralls @holgerd77