-
Notifications
You must be signed in to change notification settings - Fork 38
Migrate browser folder files to typescript & fix npm build #155
Conversation
7d69cef
to
99e9efa
Compare
4c42861
to
a14901b
Compare
a14901b
to
eca51d7
Compare
Side question for my understanding (and since I would find it pretty interesting to apply as well: does this "NB: PR targets..." trigger this "Base automatically changed" message or does this always happen if one targets another branch than Haven't worked in such a branch cascade before but am constantly battling with similar situations... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@@ -21,6 +21,7 @@ jobs: | |||
- uses: actions/checkout@v2 | |||
- run: npm install | |||
- run: npm run lint | |||
- run: npm run build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, super useful
Good question! - it's definitely new right? Just made the notes for clarity and think this must be the correct explanation:
|
#148
NB: PR targets #153
PR
browser/
file set to TS and aligns with new typescript config from Upgrade to @ethereumjs/config-typescript #152RlpxPeer depends on two Node platform modules which aren't available in the browser:
net
anddgram
. These probably need to be resolved to some alias.Have configured webpack to ignore that problem for the moment so
npm run build
runs in some fashion for the monorepo transition.#108 advises that we add a basic test to check the browser build, perhaps we can address whether or not the bundle is valid as part of that.