This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
Upgrade to @ethereumjs/config-typescript #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
commented
Oct 21, 2020
| "include": ["browser/index.js"], | ||
| "exclude": ["lib/index.js"], | ||
| "compilerOptions": { | ||
| "outDir": "dist.browser", | ||
| "target": "es5", | ||
| "lib": ["es5"], | ||
| "alwaysStrict": true |
There was a problem hiding this comment.
Here and in the configs below, have removed options which are already included in the default configs.
alwaysStrict is a sub-category of strict, which TS handbook describes as:
Enables all strict type checking options. Enabling --strict enables --noImplicitAny, --noImplicitThis, --alwaysStrict, --strictBindCallApply, --strictNullChecks, --strictFunctionTypes and --strictPropertyInitialization
This was referenced Oct 21, 2020
cgewecke
force-pushed
the
upgrade/config-typescript
branch
from
05c1626
to
7d95394
Compare
This was referenced Oct 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#148
tapeimports as necessaryNotes
npm run buildis broken prior to this PR and will require substantial work to get running. The relevant entry points still need to be ported to TS, etc. Have not altered those script commands. (Addressed in Migrate browser folder files to typescript & fix npm build #155)