Activating Istanbul #68
Conversation
|
🙂👍 Cool! This already looks generally good on first sight, let me know once this is ready for a review. Slowly getting back to work, lol. 😛 |
|
awesome! :) |
src/hardforks/constantinople.json
Outdated
| }, | ||
| "extcodehash": { | ||
| "v": 400, | ||
| "d": "Cost of EXTCODEHASH operation" | ||
| } |
There was a problem hiding this comment.
When I added the repricing for EXTCODEHASH in istanbul, I realized it didn't have the initial price set.
There was a problem hiding this comment.
Ah, just realizing that we had this discussion already on the VM side (sorry, didn't read closely your second point on the TODO list), and we found a solution here already (I stumbled upon the exact same thing).
Can you please remove the last two price-related commits and just leave this to the Istanbul block number update?
Side note: sorry, #61 should have been closed. Please don't trust issues being up-to-date too much atm, this is one larger part of my back log re-taking on a more active issue management. In doubt ask before starting on something, otherwise this might lead to frustration and/or double work.
evertonfraga
force-pushed
the
activate-istanbul
branch
from
49ba174
to
f90c48e
Compare
|
@holgerd77 changes performed, now the PR only changes block number activation and minor documentation. |
Closes #61