Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use positional path in lint scripts #39

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

holgerd77
Copy link
Member

Attempt to fix ethereumjs/ethereumjs-monorepo#913, will trigger a test run there.

@holgerd77
Copy link
Member Author

Works. 😄

This is now open for review. Script looses a bit on flexibility regarding the invocation scenarios - see here on StackOverflow for context. I would think this should be sufficient though since our usage scenarios are pretty well defined - also tested this locally and script also works.

Copy link

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@holgerd77 holgerd77 merged commit 1b83bb5 into master Oct 19, 2020
@holgerd77 holgerd77 deleted the use-positional-path-selection-in-lint-scripts branch October 19, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants