You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hardhat now broke along two releases we have done, the latest on the @ethereumjs/txv3.3.0 release where there needed to be a hotfix which then was applied here NomicFoundation/hardhat#1641.
Both breakages would likely be able to have been prevented with running Hardhat E2E tests, so we should prioritize an integration. E2E tests have been first introduced by @cgewecke in #1134 on a selected third party target (https://github.com/NoahZinsmeister/as-you-permit) (note that the intial description of the PR is misleading since we first had a somewhat differing goal (run/test old EthereumJS library versions in the VM) and then switched over to the goal of testing third-party upstream libraries (like Hardhat) within the context of our libraries as they currently are on master respectively a new PR towards master).
This initial E2E target needed to be disabled (see #1284) since it wasn't reliable. We nevertheless can take this first work as a blueprint respectively the whole integration as a basis to integrate Hardhat E2E tests.
Depending on the CI run times added these kind of tests might to be run along a PR or alternatively also as nightly tests (like the Node tests, see node-versions.yml as reference for an integration).
After having integrated Hardhat (or parts of the Hardhat tests) it might also make sense to expand to other libraries (e.g. Web3.js), just as some side note.
Ah, and as some side note: it would be nice if the E2E test documentation would get some overhaul and/or improvements along this work. This should be also renamed with capital letters testing.md -> E2E_TESTING.md or something to better align with other similar documents like README.md and for better distinction from all the config files in this folder.
Hardhat now broke along two releases we have done, the latest on the
@ethereumjs/tx
v3.3.0 release where there needed to be a hotfix which then was applied here NomicFoundation/hardhat#1641.Both breakages would likely be able to have been prevented with running Hardhat E2E tests, so we should prioritize an integration. E2E tests have been first introduced by @cgewecke in #1134 on a selected third party target (https://github.com/NoahZinsmeister/as-you-permit) (note that the intial description of the PR is misleading since we first had a somewhat differing goal (run/test old EthereumJS library versions in the VM) and then switched over to the goal of testing third-party upstream libraries (like Hardhat) within the context of our libraries as they currently are on
master
respectively a new PR towardsmaster
).This initial E2E target needed to be disabled (see #1284) since it wasn't reliable. We nevertheless can take this first work as a blueprint respectively the whole integration as a basis to integrate Hardhat E2E tests.
Depending on the CI run times added these kind of tests might to be run along a PR or alternatively also as nightly tests (like the Node tests, see node-versions.yml as reference for an integration).
After having integrated Hardhat (or parts of the Hardhat tests) it might also make sense to expand to other libraries (e.g. Web3.js), just as some side note.
//cc @alcuadrado @fvictorio
The text was updated successfully, but these errors were encountered: