Common: Add new isActivatedEIP() method #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holgerd77
commented
Feb 22, 2021
| @@ -4,7 +4,7 @@ | |||
| "comment": "Simple subroutines for the EVM", | |||
| "url": "https://eips.ethereum.org/EIPS/eip-2315", | |||
| "status": "Draft", | |||
| "minimumHardfork": "berlin", | |||
| "minimumHardfork": "istanbul", | |||
There was a problem hiding this comment.
This is a fix, EIP can technically be applied earlier than berlin, this would otherwise not allow to instantiate the VM with istanbul and just activate this single EIP.
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
50 tasks
| return true | ||
| } | ||
| for (const hfChanges of HARDFORK_CHANGES) { | ||
| const hf = hfChanges[1] |
There was a problem hiding this comment.
Had to do a double take here, this is a bit hard to read (but is due to how these hardforks are exposed). But yeah, this looks fine.
This was referenced Feb 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method
Common.isActivatedEIP(). This method is meant to replace manual calls likethis._vm._common.eips().includes(2929)(see e.g. here) which will break once such an EIP moves to a HF.After merging all these calls - particularly in the VM - should be replaced with the functionality from here.
Note that the current terminology around the term "active" in the
Commonlibrary is very unfortunate (I once introduced myself). Other methods likeactiveHardforks()take "active" as "being a part of the chain" - if activated or not. I therefor for now used the terminology "activated" to differentiate here at least a bit. I will add a note to the major-release-note planning, these old "active" names should be replaced with something less ambiguous.For now all this should work out.