Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tx Renaming / Improve backwards-compatibility #1138

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Tx Renaming / Improve backwards-compatibility #1138

merged 3 commits into from
Mar 5, 2021

Conversation

holgerd77
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 5, 2021 •
edited
Loading

Codecov Report

Merging #1138 (711a643) into master (11a29cf) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

Flag Coverage Δ
block 81.61% <100.00%> (-0.18%) ⬇️
blockchain 84.13% <ø> (ø)
client 87.07% <ø> (ø)
common 87.29% <ø> (ø)
devp2p 84.19% <ø> (ø)
ethash 82.08% <ø> (ø)
tx 86.00% <95.65%> (ø)
vm 81.67% <37.50%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

Ok, this is now ready for review (feel also free to complete yourself) and should help on #1130 and #1118. 😄

@cgewecke cgewecke mentioned this pull request Mar 5, 2021
Closed
ryanio
ryanio approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, lgtm!

@holgerd77 holgerd77 merged commit 2e77693 into master Mar 5, 2021
@holgerd77 holgerd77 deleted the improve-tx-backwards-compatibility branch March 5, 2021 17:53
@jochem-brouwer
Copy link
Member

Yup, great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

@jochem-brouwer jochem-brouwer Awaiting requested review from jochem-brouwer

@cgewecke cgewecke Awaiting requested review from cgewecke

Assignees
No one assigned
Labels
package: block package: tx package: vm PR state: needs review prio: P3 important type: enhancement type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerd77 @jochem-brouwer @ryanio