Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devp2p: implement ETH/65 #1159

Merged
merged 3 commits into from
Mar 23, 2021
Merged

devp2p: implement ETH/65 #1159

merged 3 commits into from
Mar 23, 2021

Conversation

holgerd77
Copy link
Member

No description provided.

…_HASHES, GET_POOLED_TRANSACTIONS, POOLED_TRANSACTIONS), added tests
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1159 (62f4370) into master (4bd73d1) will increase coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

Flag Coverage Δ
block 81.96% <ø> (+0.13%) ⬆️
blockchain 84.13% <ø> (-0.07%) ⬇️
client 84.00% <100.00%> (+0.13%) ⬆️
common 86.87% <ø> (-0.53%) ⬇️
devp2p 84.34% <62.50%> (+0.16%) ⬆️
ethash 82.08% <ø> (ø)
tx 84.25% <ø> (+0.19%) ⬆️
vm 81.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

Ok, this is directly ready for review, TBH the major part of the work actually will start when implementing the protocol messages itself in the client and answer them.

Since we also have various other messages not yet implemented I guess it is ok though to integrate, then we have at least the devp2p part ready.

Tested this in the client, new protocol version is used and the new message types are coming in:

image

Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, looks good

@ryanio ryanio merged commit e4eb328 into master Mar 23, 2021
@ryanio ryanio deleted the devp2p-implement-eth65 branch March 23, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants