Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trie: remove use of deprecated setRoot #1376

Merged
merged 6 commits into from
Jul 26, 2021
Merged

trie: remove use of deprecated setRoot #1376

merged 6 commits into from
Jul 26, 2021

Conversation

acolytec3
Copy link
Contributor

Small change to remove internal use of deprecated setRoot method in trie package

@codecov
Copy link

codecov bot commented Jul 26, 2021 •
edited
Loading

Codecov Report

Merging #1376 (0259fd4) into master (8b358df) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 85.90% <ø> (ø)
blockchain 83.49% <ø> (ø)
client 83.70% <ø> (-0.32%) ⬇️
common 92.70% <ø> (-0.32%) ⬇️
devp2p 83.42% <ø> (+0.03%) ⬆️
ethash 82.83% <ø> (ø)
tx 88.24% <ø> (-0.12%) ⬇️
vm 79.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@acolytec3
Copy link
Contributor Author

While working in the baseTrie file, I noticed we were still using a deprecated setRoot method in some of our internal logic. I've updated the root setter to use the correct logic from setRoot and adjusted our internal usage accordingly so we're no longer using a deprecated method.

ryanio
ryanio approved these changes Jul 26, 2021
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryanio ryanio merged commit 6461858 into master Jul 26, 2021
@ryanio ryanio deleted the remove-set-root branch July 26, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

Assignees
No one assigned
Labels
package: trie PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acolytec3 @ryanio