-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devp2p: Per-Message debugging for ETH and other protocols / Improved docs #1449
Conversation
…d debug logging documentation
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
…T_PEER first-connected-peer debugger
Aaaand two final debuggers which are very close to my heart and which I think will be super useful: An IP based per-peer debugger, e.g. And a special debugger only debugging the message exchange with the first successfully connected peer, used with Ok. Ready for review. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is beautiful, I like it, and I approve this message. I dig all the additional debug visibility. I kinda wish I had all of this when I started on the snappy/NEW_BLOCK stuff 😉
@acolytec3 Yes, totally looking forward to use this stuff myself 😄, thanks for approving! |
(pain has grown too strong here over the months... 😜) |
This PR adds per-message debugging on the devp2p library for the ETH protocol as well as other protocols. This should hopefully significantly help us on a more targeted debugging along client development.
Per-Message debugging can be used as follows, see also the additions to the docs for more information:
Example output: