Util: More explicit EIP-1191 checksum usage discouraged note / Client: remove Rinkeby from CLI test matrix #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Ok, Hardhat E2E tests are not yet working, I will open a dedicated issue for that. PR can be nevertheless reviewed and merged independently from this. |
…IP-1191 compatible checksums with toChecksumAddress() being discouraged
…n leading to CI failures
holgerd77
force-pushed
the
util-eip-1191-checksum-method-discouraged-note
branch
from
e34a220
to
20f221e
Compare
holgerd77
changed the title
holgerd77
deleted the
util-eip-1191-checksum-method-discouraged-note
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a more explicit note on
toChecksumAddress()that the usage of EIP-1191 is discouraged due to the lack of backwards compatibility to the existing checksum format.On a side line it also tests the reactivation of the E2E hardhat tests which I have reactivated in the Actions tab and where a fixing PR has been submitted on the Hardhat side here #1391 by @ryanio which should have solved the test-breaking issue.